I always think Code Reviews (or Pull Requests) are very important, but there seems a lot of people don’t seem motivated to actually do them.
I’ve complained to my team members for not engaging with Pull Requests. We say that we need 2 approvers before code can be checked in, but yet only 2 people (other than me) do them within a reasonable time, and there are 7 of us. So if someone is on annual leave, then the Pull Request is more than likely gonna stay there in limbo.
After complaining on two occasions, Sean finally completes one within minutes of one coming through. “Brilliant!” I thought, my words have finally got through.
I had a quick skim through the code and I was concerned about how many Unit Tests had been temporarily removed. Yet, Sean hadn’t actually flagged that up in his comments! He had overlooked such a blatant error.
The comment Sean left on the unit tests was: “no new line at the end of file”. That’s such a trivial thing, and GitHub actually flags that up for you anyway. There were some other comments on other files where Sean claimed that the “Code Analysis would flag these lines up”; however the developer hadn’t even changed these lines. The report wouldn’t have complained about them.
So he made a redundant comment, and some incorrect comments, and overlooked the massive problem that the developer had actually removed some tests. Presumably because his new changes broke existing functionality. It was definitely not ready for Code Review. It gets a good old “Needs Work” from me.
Maybe some developers just aren’t good at looking at code…
Stranger Coding Tings 